Overhaul to_str_common and char::escape_*
#7465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ |
|
@cmr, I think that accidentally went on the pull request instead of the commit. |
|
heh, oops! guess I commented in the wrong tab :p |
This allows the integral paths to avoid allocations on the heap Closes rust-lang#4424, rust-lang#4423
bors
added a commit
that referenced
this pull request
Jun 30, 2013
This stems from trying to perform as few allocations as possible throughout the standard libraries. This specializes the `ToStr` implementation for floats/ints separately because it's known that ints will have a maximum length (whereas floats could be very very large). I also removed a `FIXME` to remove a malloc from the `to_str()` of floats in `repr.rs` because I think that this should be addressed elsewhere. I think that we may not be able to avoid it easily because floats can have such large representations, but regardless this should be a problem with the implementation of `float_to_str_bytes_common` now and not in the `Repr` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stems from trying to perform as few allocations as possible throughout the standard libraries.
This specializes the
ToStrimplementation for floats/ints separately because it's known that ints will have a maximum length (whereas floats could be very very large).I also removed a
FIXMEto remove a malloc from theto_str()of floats inrepr.rsbecause I think that this should be addressed elsewhere. I think that we may not be able to avoid it easily because floats can have such large representations, but regardless this should be a problem with the implementation offloat_to_str_bytes_commonnow and not in theReprmodule.